Skip to content

WAF: Ensure that non-set $_SERVER['REQUEST_METHOD'] is treated the same as CLI in the sense that the WAF is skipped.#49465

Merged
ArSn merged 2 commits into
trunkfrom
fix/protect-174-cli-cron-403
Jun 12, 2026
Merged

WAF: Ensure that non-set $_SERVER['REQUEST_METHOD'] is treated the same as CLI in the sense that the WAF is skipped.#49465
ArSn merged 2 commits into
trunkfrom
fix/protect-174-cli-cron-403

Conversation

@ArSn

@ArSn ArSn commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Supersedes #49458

Proposed changes

  • Skip WAF rule evaluation when $_SERVER['REQUEST_METHOD'] is empty, treating any non-HTTP context the same as CLI (PHP_SAPI cli).
  • Add a regression test (testRunSkipsRulesWhenRequestMethodIsAbsent) verifying that Waf_Runner::run() starts but returns early without including the rules file when no request method is present.

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

CI should cover it.

@ArSn
WAF: Ensure that empty $_SERVER['REQUEST_METHOD'] is treated the same…
f571c29 
… as CLI in the sense that the WAF is skipped.
@github-actions

github-actions Bot commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/protect-174-cli-cron-403 branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/protect-174-cli-cron-403

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions

github-actions Bot commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jun 8, 2026
@jp-launch-control

jp-launch-control Bot commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@ArSn ArSn mentioned this pull request Jun 11, 2026
Closed
3 tasks
@ArSn ArSn added the [Status] Needs Review This PR is ready for review. label Jun 11, 2026
@ArSn
Change the check to "! isset" to be even safer in detecting CLI envir…
c843a64 
…onments. Ensure the tests always clean up after themselves.
@ArSn ArSn changed the title WAF: Ensure that empty $_SERVER['REQUEST_METHOD'] is treated the same as CLI in the sense that the WAF is skipped. WAF: Ensure that non-set $_SERVER['REQUEST_METHOD'] is treated the same as CLI in the sense that the WAF is skipped. Jun 11, 2026
@ArSn ArSn requested a review from a team June 11, 2026 16:11
@ArSn ArSn merged commit ae6a47b into trunk Jun 12, 2026
80 checks passed
@ArSn ArSn deleted the fix/protect-174-cli-cron-403 branch June 12, 2026 11:41
@github-actions github-actions Bot removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] Needs Review This PR is ready for review. labels Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macbre macbre macbre approved these changes

Assignees

No one assigned

Labels

[Package] WAF [Tests] Includes Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ArSn @macbre